-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Solari: Light leak reduction and stochastic WC update #22348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solari: Light leak reduction and stochastic WC update #22348
Conversation
| const WORLD_CACHE_POSITION_BASE_CELL_SIZE: f32 = 0.15; | ||
| /// How fast the world cache transitions between LODs as a function of distance to the camera | ||
| const WORLD_CACHE_POSITION_LOD_SCALE: f32 = 8.0; | ||
| const WORLD_CACHE_POSITION_LOD_SCALE: f32 = 15.0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how hard will it be to make all these constants uniforms tweakable from Resource someday?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Easy, just not a priority atm. It's on the tracking issue.
ChristopherBiscardi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

Objective
Solution
To prevent light leaks:
Since this then greatly increases the number of cache cells in the scene, I changed the following to prevent too much of a decrease in performance (this PR is still a hit to performance though):
Also some misc changes:
Ideally the skipped cells wouldn't be totally random, and we'd have coarser-LOD cells update less frequently, but that would get very complicated as we'd have to track the total amount of cells per LOD in order to average out to
WORLD_CACHE_TARGET_CELL_UPDATES.